Unity-Technologies / Unity-Technologies/NativeAudioPlugins
Multiband attack and release are broken
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 169
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Description
This commit:
https://github.com/Unity-Technologies/NativeAudioPlugins/commit/fd08cdc7e1468f7b077e494c71cde9381ae7d0db
Changed the lines from:
atk = GetTimeConstant(0.99f, _atk);
rel = GetTimeConstant(0.99f, _rel);
to:
atk = GetTimeConstant(0.99f, atk);
rel = GetTimeConstant(0.99f, rel);
which means atk and rel are never being set correctly.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting commit fd08cdc7e1468f7b077e494c71cde9381ae7d0db and locate the multiband attack and release implementation. Compare the current assignments with the two lines cited in the issue, then run the existing audio-plugin test or reproduction path, if present. Done means both parameters are set from the intended values and attack/release behavior is verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100