Unity-Technologies / Unity-Technologies/NativeAudioPlugins
NoiseBox addperiod/mulperiod copy paste issue?
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 169
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Description
Instead of
[...] if (data->mulcount >= addperiod)
it should compare to 'mulperiod', right?
[...] if (data->mulcount >= mulperiod)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open NativeCode/Plugin_NoiseBox.cpp at line 110 and inspect the period comparison in context, including how addperiod and mulperiod are defined and used. Verify the intended comparison from the surrounding NoiseBox logic, then build or run the plugin's available checks. Done means the copy-paste condition uses the correct period value without changing unrelated behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100