km_link=true in pm2 env breaks on pm2 restart app
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 43.3k
- Forks
- 2.7k
- PR merge metrics
- No merged PRs in 30d
Description
What's going wrong?
parse-error in .nvm/versions/node/v10.22.1/lib/node_modules/pm2/lib/API/UX/pm2-describe.js:179
when it tires to parse **km_link: true** with .splice().
How could we reproduce this issue?
Install pm2 with keymetrics enabled.
I'm having two apps running in pm2. app1 and app2.
app1 triggers the other to restart through "pm2 restart app2"
I'm using this:
const exec = util.promisify(require('child_process').exec)
exec("pm2 restart app2")
On restart it seems that all the ENV vars are read again - parsing to km_link: true breaks when it tries to split the boolean etc.
The fix
Is to currently disable keymetrics to have km_link: false
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at lib/API/UX/pm2-describe.js:179 and reproduce with two apps where app1 runs "pm2 restart app2" while keymetrics is enabled and km_link=true. Trace the environment parsing around the boolean and verify that restarting app2 no longer raises the parse error while km_link remains enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs
- Domain
- cli, devops
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100