Uniswap / Uniswap/interface

Keep URL synced with swap interface

Open
#972 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

improvement p1
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Is your feature request related to a problem? Please describe.

It seems that uniswap does not detect the hashtag change in the URL ( tough it would change when swapping between currencies, and would require to have an "ignore" functionality in that part if it's already set on the interface or still processing.

Describe the solution you'd like

I'd like for uniswap to detect the hashchange, and update the currencies accordingly, this seems very practical if using bookmarks, and in general it's a best practice on the web.

Additional context

Simple video showcasing the issue : https://d.pr/v/nlqFyh

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the swap interface's URL and hash-change handling in the TypeScript code, then reproduce the behavior by switching currencies and loading a bookmarked URL. Done means hash changes update the selected currencies without overriding an interface state that is already set or still processing.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.