[Bug] Incorrectly High Price Impact Displayed for Pools with Hook-Based Fees
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
📱 Interface Affected
Which application are you experiencing issues with?
- Web (app.uniswap.org)
- Wallet Extension (wallet.uniswap.org)
- Wallet Mobile App
- iOS
- Android
- Both
🧩 App Version
- Version (if known):
- Production build
- Development build
💻 System / Environment Info
Please provide details about your environment:
- Browser (name + version): chrome
- OS / Platform (e.g. iOS 17, Windows 11, Android 14): macos
- Device (e.g. iPhone 14 Pro, Pixel 7, MacBook Pro 2023): macbook m4
- Wallet used (e.g. Uniswap Wallet, MetaMask, Rainbow): metamask
- Network (e.g. Ethereum Mainnet, Arbitrum, Base, etc.): mainnet
🔁 Steps to Reproduce
- Navigate to the swap interface for a pool that utilizes a hook for its fees.
- Example Pool: https://app.uniswap.org/explore/tokens/ethereum/0xd0cC2b0eFb168bFe1f94a948D8df70FA10257196?inputCurrency=NATIVE
- Enter any amount for the input token (e.g., 0.01 ETH).
✅ Expected Behavior
The price impact should dynamically reflect the actual slippage based on the input amount relative to the pool's liquidity. For a small trade, this value should be low.
❌ Actual Behavior
The UI displays a static, high price impact (10% in the provided example) regardless of the input trade size. This suggests the fee from the hook might be being misinterpreted as price impact.
📸 Screenshots or Screen Recording
🧾 Additional Context
Any extra details? (e.g. logs, error messages, recent updates, beta flags enabled, etc.)
⚠️ Please redact or avoid sharing sensitive data such as private keys, seed phrases, or personally identifying info.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in the swap interface using the linked example pool and a small ETH amount. Trace how the web app calculates and displays price impact for pools with hook-based fees; done means the displayed impact changes with trade size and no longer shows a static 10% for the example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100