[Bug] [V2, V3, V4] quote is worse than [V3, V4] quote
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
As a user, I expect that I will receive the best exchange result in case:
- If I select
[V3, V4]protocols - And if I add
V2from the previous set[V3, V4]->[V2, V3, V4]
But the quote calculation with V2 in set gets worse.
I guess that if the liquidity in V2 does not get profit in quote, it should not be considered, as another protocols are already in set and have a better quote.
https://github.com/user-attachments/assets/fbf10b6b-492c-45ef-bba1-0888b3a5189d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the quote calculation with [V3, V4] and then [V2, V3, V4], using the linked recording as context. Trace the quote-calculation entry point and how liquidity from each selected protocol is considered; done means adding V2 no longer worsens the best available quote when it is not competitive.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100