Uniswap / Uniswap/interface

Pool overviews show values in dollar regardless of currency setting

Open
#7,799 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Pool overviews show values in dollar regardless of currency setting. An earlier update broke this in the Pools tab in the side menu, but it is now broken as well in the regular pool positions overview at https://app.uniswap.org/positions. All positions now show both the position and fees in dollars, which is of limited usefulness for most of the world where USD is a foreign currency.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the Pools tab and the regular pool positions overview at https://app.uniswap.org/positions with a non-USD currency setting. Trace the position and fee value displays from those entry points; done means both overviews use the selected currency instead of always showing dollars.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.