personal_sign params are inverted with respect to ether.js
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
In ether.js, personal_signhas payload and address params in this order
https://github.com/ethers-io/ethers.js/blob/fc66b8ad405df9e703d42a4b23bc452ec3be118f/src.ts/providers/provider-jsonrpc.ts#L435
In uniswap, we should invert params ? So we need to be specific for this wallet in DApps.
Why this difference please ?
Is it a mistake ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the personal_sign parameter order described in ethers.js provider-jsonrpc.ts at line 435 with Uniswap's current handling. The issue does not identify the Uniswap entry point or tests; completion requires determining the intended order and documenting or implementing the wallet-specific behavior after that decision.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- blockchain, typescript
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100