In WalletConnect2 session proposal, icon URL is wrong
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
It is received in the app as: https://app.uniswap.org/favicon.ico , which is a 404
It should be the same as what the website uses: https://app.uniswap.org/favicon.png
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the WalletConnect2 session proposal code that sets the app icon URL, then compare it with the favicon URLs given in the issue. Done means the proposal uses https://app.uniswap.org/favicon.png rather than the 404ing favicon.ico URL.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100