Uniswap / Uniswap/interface

Add EIP6963 Support

Open
#7,560 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

improvement
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Is your feature request related to a problem? Please describe.
I'm building a browser wallet and it does not display well in Uniswap! My wallet supports eip6963 but uniswap doesn't. I could build support for my wallet directly into uniswap frontend, but that feels ugly and a hacky solution

Describe the solution you'd like
Uniswap supports EIP6963 (https://eips.ethereum.org/EIPS/eip-6963) and will dynamically render relevant wallets users have installed when 'connect wallet button' is hit based on the eip

Describe alternatives you've considered
I can add special cases for my wallet here: https://github.com/Uniswap/interface/blob/876d3a1cc343a2ea822243b2a579f4c185722064/src/connection/utils.ts#L13

and here:
https://github.com/Uniswap/interface/blob/876d3a1cc343a2ea822243b2a579f4c185722064/src/react-app-env.d.ts#L21

Additional context
none!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the EIP-6963 specification and inspect src/connection/utils.ts and src/react-app-env.d.ts, especially the existing wallet connection and type definitions. Trace how the connect wallet button discovers and renders wallets. Done means installed EIP-6963 wallets can be discovered and dynamically shown without adding wallet-specific cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.