AVG_L1_BLOCK_TIME is incorrect / misleading
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
AVG_L1_BLOCK_TIME
We see it defined here:
https://github.com/Uniswap/interface/blob/809841df0a8fbeb98bde1780081f1170c84aa283/src/constants/chainInfo.ts#L24
Officially, L1 block time is defined here:
https://github.com/ethereum/consensus-specs/blob/dev/specs/phase0/beacon-chain.md#time-parameters-1
Furthermore, an average of 12 would be lower than any observed block times post muir-glacier in a pre-PoS setting to begin with.
Probably not a big deal, just thought to mention it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/constants/chainInfo.ts at the AVG_L1_BLOCK_TIME definition and compare its value and meaning with the Ethereum consensus-specs time parameters linked in the issue. Confirm the correct interpretation of L1 block time, then update the constant if needed; done means the value is accurate and no longer misleading.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100