Uniswap / Uniswap/interface

Missing or invalid. request() method: eth_sign

Open
#7,086 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description
Clicking "Confirm swap" on https://app.uniswap.org/#/swap fails silently with Gnosis Safe connected via WalletConnect.

Screenshot 2023-08-04 at 1 00 11 PM

Steps to Reproduce

  1. Connect the Gnosis Safe mobile wallet to app.uniswap.org using WalletConnect.
  2. Enter any amount of OETH to swap for ETH.
  3. Approve the allowance.
  4. Click "Confirm swap".
  5. See uncaught error in the console.

Demo: https://www.loom.com/share/13fc327a58574e668c5d5e04b5641f76
...

Expected Behavior
The wallet should present a prompt for signing the swap transaction.

Additional Context
It's possible that Safe + WalletConnect is not supported. I think 1inch requires me to use the Safe App within their web interface. Other dapps allow me to do what I'm attempting to do here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the swap at app.uniswap.org with a Gnosis Safe mobile wallet connected through WalletConnect, then capture the uncaught console error at the Confirm swap step. Trace the eth_sign request path and determine whether the expected result is a signing prompt or a documented unsupported combination.

Written by the indexing model from the issue text.

Assessment

Tech stack
blockchain, typescript
Domain
blockchain, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.