Uniswap / Uniswap/interface

Changing Chain does not work with all namespaces.

Open
#6,861 1 comment 1 reaction 1 assignee View on GitHub

@JFrankfurt is already working on this.

Since Jun 29, 2023.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description
When using the namespace system addressed in this pr: https://github.com/Uniswap/interface/pull/6802 and trying to change chains.

There is an error caused by this line:
const isConnectedToDesiredChain = provider.session.namespaces.eip155.accounts.some((account) => account.startsWith(`eip155:${desiredChainId}:`));

Cannot read properties of undefined (reading 'accounts')
Steps to Reproduce

  1. Connect over WalletConnect
  2. Change chain in the top left corner.

Expected Behavior
The UI should update to the selected chain and allow for transactions.

Additional Context
This was tested with Bifrost Wallet version (0.5.1).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.