Uniswap / Uniswap/interface

MobileBottomBar too short on iPhone PWA

Open
#6,557 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

The MobileBottomBar is too short and overlaps with native iPhone bar

  1. Go to app.uniseap.org on safari
  2. Click on share site
  3. Click on "Add to Home Screen
  4. Open App
Expected Behavior

There should be a space below the MobileBottomBar items so the it doesn't overlap with native iPhone bar

Screen Shots
Current
Screenshot 2023-05-12 at 3 53 56 PM
Expected
Screenshot 2023-05-12 at 3 53 30 PM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the MobileBottomBar component in the TypeScript frontend and inspect how it is sized on mobile. Reproduce the issue using the listed Safari Add to Home Screen steps, then verify that the bar has space below its items and no longer overlaps the native iPhone bar.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, typescript
Domain
frontend, mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.