Uniswap / Uniswap/interface

Can't add liquidity for invalid current price

Open
#6,433 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description
If someone added liquidity with one token for out of range price, then, others can't add liquidity later.
In this case later liquidity providers can only add one token and not two tokens to pool.

Steps to Reproduce

  1. Go to pools
  2. Click on "+ New Position"
  3. Select out range price
  4. You can see following message for one token "The market price is outside your specified price range. Single-asset deposit only."
  5. Add liquidity with only one token
  6. Later users can't provide two token liquidity any more.

Expected Behavior
Adding liquidity with only one token should be disabled and users can always add liquidity with both tokens even when outside in current price

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in Pools through “+ New Position,” using an out-of-range price and a single-token deposit. Trace the position and liquidity-add flow to determine why a later provider cannot deposit both tokens; done means single-token deposits are disabled in this situation while two-token liquidity remains possible, with regression coverage if the existing flow includes tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.