Uniswap / Uniswap/interface

Crash report: `Error: invalid decimal value (argument="value", value="0,01", code=INVALID_ARGUMENT, version=bignumber/5.6.2)`

Open
#5,473 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

URL

https://app.uniswap.org/#/nfts/profile

Error

Error: invalid decimal value (argument="value", value="0,01", code=INVALID_ARGUMENT, version=bignumber/5.6.2)

Stacktrace

Error: invalid decimal value (argument="value", value="0,01", code=INVALID_ARGUMENT, version=bignumber/5.6.2)
    at e.value (https://app.uniswap.org/static/js/4.ef60cbe2.chunk.js:2:102827)
    at e.value (https://app.uniswap.org/static/js/4.ef60cbe2.chunk.js:2:102971)
    at e.value (https://app.uniswap.org/static/js/4.ef60cbe2.chunk.js:2:103050)
    at v (https://app.uniswap.org/static/js/4.ef60cbe2.chunk.js:2:2048905)
    at s (https://app.uniswap.org/static/js/4.ef60cbe2.chunk.js:2:474654)
    at c (https://app.uniswap.org/static/js/4.ef60cbe2.chunk.js:2:474721)
    at https://app.uniswap.org/static/js/main.762c08e7.chunk.js:1:1431697
    at Array.map (<anonymous>)
    at f (https://app.uniswap.org/static/js/main.762c08e7.chunk.js:1:1431548)
    at ue (https://app.uniswap.org/static/js/main.762c08e7.chunk.js:1:1354319)

Device data

{
  "ua": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36",
  "browser": {
    "name": "Chrome",
    "version": "107.0.0.0",
    "major": "107"
  },
  "engine": {
    "name": "Blink",
    "version": "107.0.0.0"
  },
  "os": {
    "name": "Windows",
    "version": "10"
  },
  "device": {},
  "cpu": {
    "architecture": "amd64"
  }
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the crash at https://app.uniswap.org/#/nfts/profile using the reported Chrome and Windows environment, then trace the stack from the loaded JavaScript bundles. Investigate how the NFT profile handles the reported value "0,01"; done means the profile loads without the invalid decimal error and the regression is covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.