Uniswap / Uniswap/interface

Detect best price (v3 or v2)

Open
#5,190 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

I am legitimately lost in the uniswap v3 documentation.
my ultimate goal is to understand if a token is v3 or v2 with typescript, or at least define the best price, if it is in v3 or v2.

I'm currently trying to get the example to work on this documentation page. But unlike what it should be it's not a ready-to-use example, several imports and comments are missing.
Even though I can complete the example I get the following error:
"The argument of type '{data: string; to: string; value: number; from: string; gasPrice: number;}' is not assignable to the parameter of type 'string | Promise <string>'

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Uniswap SDK auto-router documentation page linked in the issue and reproduce the TypeScript error using its example. Review the missing imports, comments, and transaction-call typing; done means the example is complete and runs without the reported type error for the documented v2/v3 price flow.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.