Uniswap / Uniswap/interface

This constitutes a change in logic, disallowing previous TLDS that would resovle properly by ENS. This won't work, we'll have to find a solution that will allow both ENS and UD to resolve these TLDS based on user preference.

Open
#4,946 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

This constitutes a change in logic, disallowing previous TLDS that would resovle properly by ENS. This won't work, we'll have to find a solution that will allow both ENS and UD to resolve these TLDS based on user preference.

Originally posted by @brad-decker in https://github.com/MetaMask/metamask-extension/pull/16166#discussion_r997269481

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the referenced MetaMask pull-request discussion and tracing the interface's ENS and UD name-resolution entry points. The issue names no files, tests, or implementation scope, so first establish where resolution preference is handled and define acceptance cases for both services before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.