Uniswap / Uniswap/interface

Crash report: `TypeError: Cannot read properties of undefined (reading 'circleLogoUrl')`

Open
#4,938 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

URL

https://app.uniswap.org/#/tokens/ethereum_goerli

Error

TypeError: Cannot read properties of undefined (reading 'circleLogoUrl')

Console

Access to fetch at 'https://rinkeby.infura.io/v3/099fc58e0de9451d80b18d7c74caa7c1' from origin 'https://app.uniswap.org' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

TypeError: Cannot read properties of undefined (reading 'circleLogoUrl')
    at TokenRow.tsx:486:54
    at Sa (react-dom.production.min.js:167:137)
    at Of (react-dom.production.min.js:193:57)
    at Ss (react-dom.production.min.js:294:275)
    at gu (react-dom.production.min.js:280:389)
    at mu (react-dom.production.min.js:280:320)
    at vu (react-dom.production.min.js:280:180)
    at ou (react-dom.production.min.js:271:88)
    at iu (react-dom.production.min.js:268:429)
    at O (scheduler.production.min.js:13:203)

Stacktrace

TypeError: Cannot read properties of undefined (reading 'circleLogoUrl')
    at https://app.uniswap.org/static/js/main.3e62ed90.chunk.js:1:783554
    at Sa (https://app.uniswap.org/static/js/9.b5edc1bf.chunk.js:2:3689613)
    at Of (https://app.uniswap.org/static/js/9.b5edc1bf.chunk.js:2:3699723)
    at Ss (https://app.uniswap.org/static/js/9.b5edc1bf.chunk.js:2:3748888)
    at gu (https://app.uniswap.org/static/js/9.b5edc1bf.chunk.js:2:3735761)
    at mu (https://app.uniswap.org/static/js/9.b5edc1bf.chunk.js:2:3735689)
    at vu (https://app.uniswap.org/static/js/9.b5edc1bf.chunk.js:2:3735552)
    at ou (https://app.uniswap.org/static/js/9.b5edc1bf.chunk.js:2:3732332)
    at iu (https://app.uniswap.org/static/js/9.b5edc1bf.chunk.js:2:3730883)
    at O (https://app.uniswap.org/static/js/9.b5edc1bf.chunk.js:2:3757463)

Device data

{
  "ua": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36",
  "browser": {
    "name": "Chrome",
    "version": "106.0.0.0",
    "major": "106"
  },
  "engine": {
    "name": "Blink",
    "version": "106.0.0.0"
  },
  "os": {
    "name": "Windows",
    "version": "10"
  },
  "device": {},
  "cpu": {
    "architecture": "amd64"
  }
}

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the crash at the provided Uniswap Goerli URL and inspect TokenRow.tsx around line 486, where circleLogoUrl is read. Check how the CORS failure from rinkeby.infura.io leaves the token data undefined; done means the token page no longer crashes when that data is unavailable.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.