Uniswap / Uniswap/interface

Remove jargon from interface

Open
#4,872 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description
The summary modal box when swapping assets reads "Price Impact", and its tooltip (when hovered over) reads "The impact your trade has on the market price of this pool." No, my trade will not have an "impact" on the market price; i.e., my trade is not crashing into market price. Even in the jargon sense of "strong/violent/marked effect", having it say that makes no sense if the magnitude is anything less than, say, 10%, since it would be an oxymoron. In my screenshotted example below, that is indeed the case: a 0.00% "impact" on the price.

Steps to Reproduce

  1. Go to the Uniswap App.
  2. Choose a from asset and an amount.
  3. Choose a to asset and an amount.
  4. Click Swap.

Expected Behaviour
The word should be effect; the trade might have an effect on the price, and the number listed there will describe the magnitude of this effect. Consequently, the label should read "Price Effect" instead. I'm not sure where this jargon is coming from or why it's becoming prevalent these days.

Additional Context
Screenshot 2022-10-11 183019
Screenshot 2022-10-11 183045

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the swap summary modal by searching the interface for the displayed "Price Impact" label and its tooltip text. Update the user-facing wording to "Price Effect" and verify the swap flow shows the revised label and explanation.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.