Bug: Signature Approvals overriding Max Allowance already
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
Bug Description
Users with a max Allowance on USDC and DAI are being forced to do a signature approval, instead of the UI noticing that they already have full allowance set. Swap button shows up momentarily then goes to signature approval
Steps to Reproduce
- Go to app.uniswap.org
- With a wallet supplied with USDC with max allowance
- Add USDC to sell
- Instead of Swap, get signature approval
...
Expected Behavior
The UI should notice non signature allowance, and not force the signature
Additional Context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the flow at app.uniswap.org with a wallet holding USDC or DAI with maximum allowance, following the listed steps. Trace the allowance and signature-approval path until the UI chooses signature approval; done means an existing non-signature maximum allowance keeps the Swap button available without forcing a signature.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100