query parameter chain sync is broken
Open
@vm is already working on this.
Since Aug 17, 2022.
bug
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
Situation 1
client side navigation will sync the network query parameter, but the url itself is unusable if navigating from an external site
to repro:
- ensure wallet is disconnected from the interface
- navigate to https://app.uniswap.org/#/swap?chain=optimism
observe
- the
chainqp changes to mainnet
expected
- the user views the application (i.e., LP position nft) in the state specified by the URL
Situation 2
This is ALSO broken when the user is currently connected to the application.
to repro:
- ensure wallet is connected to the interface
- connect to Optimism
- navigate to https://app.uniswap.org/#/swap?chain=mainnet
observe
- the
chainqp changes to optimism
expected
- the user should be prompted to change their chain to mainnet
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.