Uniswap / Uniswap/interface

Walletconnect initially fetches Ethereum 'eth_blockNumber' for all networks

Open
#4,343 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description
After using walletconnect on any network other than mainnet, an invalid balance is displayed due to an invalid block number.

Steps to Reproduce

  1. Connect with wallet connect
  2. Do not refresh

Expected Behavior
The respective chains latest block is fetched and correct balance is displayed.

Additional Context

In this case the balance is correct however, previously I've seen the corresponding wallets mainnet ether balance displayed;

Screen Shot 2022-08-12 at 5 13 11 PM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the report. Start at the WalletConnect connection flow and trace the initial eth_blockNumber request; verify that it uses the connected chain rather than Ethereum mainnet, and confirm the displayed balance is correct without a refresh.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.