Uniswap / Uniswap/interface

auto price impact is not working right

Open
#4,309 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

For a trade of this size, the auto price impact of 0.5% is huge. You only lose $100 to price impact/fees, but could potentially lose $5000 to slippage

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported trade scenario and reviewing the auto price impact and slippage behavior shown in the attached screenshot. Trace where the 0.5% auto price impact is calculated or applied; done means the reported trade no longer exposes the stated disproportionate slippage risk.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.