Uniswap / Uniswap/interface

SVG image drawn on canvas with wrong dimension under Safari

Open
#4,137 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description

CleanShot 2022-07-19 at 19 00 33@2x

Steps to Reproduce

  1. Open Safari browser, either on mobile or desktop
  2. Visit https://app.uniswap.org/#/pool/1?chain=mainnet
  3. Hover your mouse over the image then move away (click it if you're on mobile)

Expected Behavior

It should render with correct dimension just like other browsers.

CleanShot 2022-07-19 at 19 05 49@2x

Additional Context

So far I can only reproduce it on Safari.

  1. Safari desktop version: 15.5
  2. Safari mobile on iOS 15.4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue at https://app.uniswap.org/#/pool/1?chain=mainnet in Safari 15.5 or iOS Safari 15.4, then compare the SVG canvas dimensions with another browser. No source file or test is named in the issue; done means the image renders at the correct dimensions after hover or tap in Safari.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.