/pool/{id} page hangs in loading state forever if there is no LP position at that id
Open
Nobody has claimed this yet.
bug
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
if you go to a page like https://app.uniswap.org/#/pool/9999999999999?chain=celo
where the id is not a valid LP position on that network you end up in this loading state forever:
todo:
- design a 404-style "position not valid--are you on the right network?" page
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue at the /pool/{id} route with an invalid LP position, such as the URL in the report, and trace where the page remains in its loading state. No file or test is named in the issue. Done means an invalid position shows a 404-style message explaining that it may be invalid or on the wrong network instead of loading forever.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100