Uniswap / Uniswap/interface

eip155 ENS Avatars aren't showing bc `uriToHttp.ts` doesn't include a case for `eip155`

Open
#3,950 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description
eip155 ENS Avatars aren't showing bc uriToHttp.ts doesn't include a case to return a fetch-able https URL for eip155 protocol URIs

Screen Shot 2022-06-21 at 2 36 43 PM

Steps to Reproduce & Expected Behavior

  1. Connect to interface via injected wallet with an address with an ENS NFT avatar set
  2. Account chip should show ENS NFT avatar

Additional Context
i.e. Hayden's ENS avatar is set to eip155:1/CryptoPunks:0xb47e3cd837dDF8e4c57F05d70Ab865de6e193BBB/6055, but uriToHttp.ts doesn't handle the eip155 case

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in uriToHttp.ts and trace how ENS avatar URIs are converted for the account chip. Reproduce with an address whose ENS avatar uses an eip155 URI, then verify that the conversion produces a fetchable HTTPS URL and the avatar appears.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.