Uniswap / Uniswap/interface

Add Red to slippage and Minimum out when slippage is greater than 10%

Open
#3,855 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

improvement
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Is your feature request related to a problem? Please describe.
When Expert mode is not enabled and the slippage on a trade is large, the pop up confirmation doesn't stress the importance of the minimum output or slippage.

Describe the solution you'd like
in this area, if Slippage greater than 10% change the font color to red on slippage and minimum output
image

Describe alternatives you've considered
larger text wouldn't hurt either, to make the slippage prominent

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the trade confirmation pop-up and the existing slippage and minimum output labels in the interface. Check how the slippage value is represented, then verify that both labels visibly change when slippage exceeds 10% and remain unchanged at or below that threshold.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.