Uniswap / Uniswap/interface

Crash report: `Error: invalid BigNumber string (argument="value", value="erc721", code=INVALID_ARGUMENT, version=bignumber/5.6.0)`

Open
#3,852 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

URL

https://app.uniswap.org/#/swap?chain=mainnet

swap state

{
  "INPUT": {
    "currencyId": "ETH"
  },
  "OUTPUT": {
    "currencyId": null
  },
  "independentField": "INPUT",
  "typedValue": "",
  "recipient": null
}

Error

Error: invalid BigNumber string (argument="value", value="erc721", code=INVALID_ARGUMENT, version=bignumber/5.6.0)

Stacktrace

Error: invalid BigNumber string (argument="value", value="erc721", code=INVALID_ARGUMENT, version=bignumber/5.6.0)
    at e.value (https://app.uniswap.org/static/js/3.41edfc8a.chunk.js:2:83145)
    at e.value (https://app.uniswap.org/static/js/3.41edfc8a.chunk.js:2:83289)
    at e.value (https://app.uniswap.org/static/js/3.41edfc8a.chunk.js:2:83368)
    at Function.value (https://app.uniswap.org/static/js/3.41edfc8a.chunk.js:2:173013)
    at Qn (https://app.uniswap.org/static/js/main.19d4c78b.chunk.js:1:365204)
    at Hn (https://app.uniswap.org/static/js/main.19d4c78b.chunk.js:1:364034)
    at https://app.uniswap.org/static/js/main.19d4c78b.chunk.js:1:366279
    at Zn (https://app.uniswap.org/static/js/main.19d4c78b.chunk.js:1:366502)
    at oa (https://app.uniswap.org/static/js/3.41edfc8a.chunk.js:2:1938523)
    at za (https://app.uniswap.org/static/js/3.41edfc8a.chunk.js:2:1948090)

Device data

{
  "ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/101.0.4951.54 Safari/537.36",
  "browser": {
    "name": "Chrome",
    "version": "101.0.4951.54",
    "major": "101"
  },
  "engine": {
    "name": "Blink",
    "version": "101.0.4951.54"
  },
  "os": {
    "name": "Mac OS",
    "version": "10.15.7"
  },
  "device": {},
  "cpu": {}
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the crash at the supplied Uniswap swap URL with the recorded swap state, then trace the minified stack back to the corresponding source entry point. Identify why the value "erc721" reaches BigNumber parsing and add regression coverage demonstrating that the swap page no longer crashes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.