Full range Button only works when token 0 is selected
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
Bug Description
Currently when trying to make a full range position the UI will only set the full range when the token direction is selected with token 0.
Steps to Reproduce
- Go to https://app.uniswap.org/#/add/ETH/0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48/3000?chain=mainnet&minPrice=1040.312550&maxPrice=4161.250200
(random pool) - Click on Full range button, UI will not fill in full range
- Click on USDC top right of add lq window, and now UI will fill in full range values
...
Expected Behavior
UI would allow full range whichever token direction is selected
The UI would use max low tix and max high tick in proper token0 -> token1 position (my though thinking ui is putting upper/lower tick in wrong position, causing UI to bug out and not set at all
Additional Context
clicking USDC (or token 0) top right will allow the UI to set pool to full range.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue at the provided add-liquidity URL by selecting Full range with each token direction. Trace the full-range button's token-direction handling and verify that the UI sets the proper lower and upper values in both directions; done means full range works without switching to token 0.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100