Loading spinner disappears at narrow widget
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
Desktop. At normal window width, an animated spinner svg appears while the app is fetching a quote form the Auto Router
At more narrow window widths, the animated spinner gets hidden. However there is still plenty of space in the swap box to show the spinner. In fact the swap box doesn't change at all at this width, so there's no reason to hide the spinner.
Here's the relevant line of code: https://github.com/Uniswap/interface/blob/main/src/components/swap/SwapDetailsDropdown.tsx#L144
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/components/swap/SwapDetailsDropdown.tsx at line 144 and reproduce the quote-fetching state at normal and narrow desktop widths. Inspect why the animated spinner SVG is hidden at the narrower width, then verify that it remains visible while the Auto Router fetches a quote without changing the swap box layout.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100