Uniswap / Uniswap/interface

useCurrentBlockTimestamp should return a number

Open
#3,477 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

(1) useCurrentBlockTimestamp should be a number and (2) it might be the same as useBlockNumber

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation and usages of useCurrentBlockTimestamp, then compare it with useBlockNumber. Determine whether the timestamp should be numeric and whether the two hooks are intended to share behavior. Done means the return type and relationship between the hooks are clarified and the affected behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.