Uniswap / Uniswap/interface

Icon not shown on Swap when selected outside of list

Open
#3,290 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description
If I look for a token that belongs to a list that I have not added, it lets me import it but the icon is not shown.

Steps to Reproduce

  1. Go to https://app.uniswap.org/#/swap?chain=mainnet
Screen Shot 2022-02-10 at 3 14 54 PM
  1. Click on Manage Token Lists. Make sure coingecko and marketcap are not selected.
Screen Shot 2022-02-10 at 4 31 49 PM
  1. Look for token BABL and click Import
Screen Shot 2022-02-10 at 4 32 41 PM
  1. Click accept on the notice
Screen Shot 2022-02-10 at 4 33 08 PM
  1. Icon doesn't show after selection
Screen Shot 2022-02-10 at 4 33 35 PM

Expected Behavior
The correct Icon to show after selection.

Additional Context
If I have coinmarketcap or coingecko list selected as token lists it displays correctly

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in the Swap interface with the CoinGecko and Marketcap lists disabled, then inspect the token search, import, and selection flow. Done means the imported BABL token displays its correct icon after selection, matching the behavior when those token lists are enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.