Uniswap / Uniswap/interface

Request wallet to match the app network upon connect

Open
#3,181 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Steps to Reproduce

  1. Visit app.uniswap.org
  2. Disconnect your wallet from the app
  3. Switch your wallet to Ethereum
  4. Switch the app to Polygon
  5. Now click 'Connect wallet' in the app

Actual Behavior
The wallet connects on Ethereum and completely overrides the app state = Polygon.

Expected Behavior
The app says Polygon and I'm looking at a price quote on Polygon, so I expect my wallet to connect to Polygon network.

This bug was made more prevalent by two recent launches

  1. The ability to switch networks in the unconnected state. It's not very easy for the user's wallet to mismatch the app.
  2. Chainid as a URL param. Users will now be pointed directly to a particular chain

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Reproduce the listed wallet and app network steps first, then trace the connection and network-selection entry points; done means connecting while the app is on Polygon keeps the wallet and price quote on Polygon.

Written by the indexing model from the issue text.

Assessment

Tech stack
blockchain, typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.