Uniswap / Uniswap/interface

Wallet connect JSON-RPC responses don't seem to reach the React interface

Open
#3,158 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description

When connecting a wallet via Wallet Connect, any wallet action (eg: swap) will trigger a JSON RPC method which even if successfully handled, and responded by the wallet, (even broadcasted and validated on chain) the interface will be stuck on "waiting for wallet confirmation".

Steps to Reproduce

I came across this while developing my own wallet but I verified this also happens with MetaMask for Android:

  1. Open Uniswap dapp in browser
  2. Select connect wallet
  3. Select Wallet Connect
  4. Scan QR with MetaMask for Android (or other WC enabled wallets)
  5. Try to do any action like swap eth for uni
  6. Confirm action on wallet
  7. Dapp is still stuck on "Waiting For Confirmation - Confirm this transaction in your wallet"

Expected Behavior
The action Modal should close after the RPC-Response

Other

This makes it impossible to reply to eth_signTypedData_v4 method during ERC20 permit because the reponse isn't triggering a state change in the interface that the permit was signed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Wallet Connect flow in the React interface and reproduce the swap using the listed steps, including confirmation in MetaMask for Android. Trace how the JSON-RPC response reaches the action modal and permit state; done means the modal closes after a successful response and the interface no longer waits for confirmation.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.