Uniswap / Uniswap/interface

Add support to natively connect to Frame wallet

Open
#3,102 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

improvement
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Is your feature request related to a problem? Please describe.
Metamask's (the most common wallet app) connectivity to hardware wallets (e.g. Ledger) has always been slow. frame.sh seems to be a new(ish) wallet app that offers much faster connectivity to Ledger/Trezor/Lattice for tx signing, and so it will be great if Uniswap UI supports connecting to Frame natively.

Describe the solution you'd like
For Frame to be added to the "Connect a wallet" list of Uniswap UI, using native connection (i.e. without needing Frame's browser extensions).

Describe alternatives you've considered
The 'injected' method of connecting to Frame (via browser extension) requires installation of the browser extension, and is not ideal.

Additional context
Anecdotally, Frame's support of Ledger/Trezor/Lattice is great, with much faster speed going from Uniswap UI "Swap" button to actual hardware button press to sign tx. I only have Ledger, and can confirm that it is indeed much faster to get to tx signing via Frame (compared to Metamask).

Resources for implementation of native connectivity to Frame:
https://github.com/floating/frame
https://github.com/floating/eth-provider

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Uniswap UI’s “Connect a wallet” flow and review the Frame and eth-provider repositories linked in the issue. Determine how native Frame connectivity should appear in the wallet list and support transaction signing without the browser extension. Done means Frame can connect and reach hardware-wallet signing through the Uniswap UI.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.