Uniswap / Uniswap/interface

Network/chainId in URL params v2

Open
#3,074 2 comments 1 reaction 1 assignee View on GitHub

@tinaszheng is already working on this.

Since Jan 10, 2022.

improvement
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Is your feature request related to a problem? Please describe.
When there is a chainId parameter in the URL, ideally, the app should not automatically trigger a network request change in your wallet on load.

Describe the solution you'd like
It should instead:

  • display data on the app from the new chainId
  • network indicator + action buttons should prompt you to change to the new chainId

that way, users who won't make a transaction can still look at app data on the correct chain without changing networks on their wallet

https://www.figma.com/file/M92SdNLzrYhQ6OfcJMeENM/Layer-2?node-id=1502%3A93

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.