Uniswap / Uniswap/interface

refactor useActiveWeb3React usage for widget

Open
#2,890 0 comments 0 reactions 1 assignee View on GitHub

@JFrankfurt is already working on this.

Since Nov 30, 2021.

improvement p0
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
No merged PRs in 30d

Description

some hooks necessary for swap functionality rely on useActiveWeb3React in the current interface

  • useUSDCValue - chainId (3x)
  • useCurrency - chainId (1x)
  • useENSAddress -> useSingleCallResult -> useSingleContractMultipleData -> useBlockNumber - chainId
    These should be refactored to consume chainId as an argument, or the useActiveWeb3 implementation should be updated to support the new web3-react lib

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.