Uniswap / Uniswap/interface

Standardize proposal numbers 1-9

Open
#2,866 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue improvement
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

/vote/ page now counts proposals as

  • 0.1
  • ...
  • 1.1
  • 2.9

where the major version corresponds to the governor contract version: alpha1, alpha2, bravo

Now that the Governor Bravo has stabilized we should normalize proposal numbers as 1, 2, 3,... 9. This can be done by hard coding the proposal numbers.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the /vote/ page and trace the code that renders proposal numbers, checking how Governor Bravo proposal identifiers are currently displayed. Confirm that the first nine proposals appear as 1, 2, 3 through 9, and verify the page still renders proposal voting information correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.