Uniswap / Uniswap/interface

Remove useBestV2Trade from the interface

Open
#2,808 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

improvement refactor
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Only remaining dependency should be https://github.com/Uniswap/interface/blob/main/src/hooks/useUSDCPrice.ts#L28

Few options

  • Rely on client-side v3 router only (won't pick up long tail assets)
  • Use client-side smart-order router (possible when L2s supported)
  • Write simplified logic similar to what we had before

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the remaining useBestV2Trade dependency in src/hooks/useUSDCPrice.ts at line 28 and searching the interface for other references. Review the three routing approaches listed in the issue, then establish which one is selected before changing anything. Done means the dependency is removed from the interface and the replacement behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.