Uniswap / Uniswap/interface

Two tokens showing wrong price due to token decimals being off

Open
#2,751 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug p1
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description
Right now two tokens are giving a bad price off by 9 decimals. I believe it to be from a token list, but I have not found a list that has the wrong decimals.
Tokens that we have found as of now are
Luffy Inu -- 0xC1bfcCd4c29813eDe019D00D2179Eea838a67703
Saitama -- 0x8B3192f5eEBD8579568A2Ed41E6FEB402f93f73F

Both show the price but 9 decimals short

Steps to Reproduce

  1. Go to app.uniswap.org
  2. load either token
  3. price is only showing wrong for x percent ( I don't see )

...

Expected Behavior
Load with correct price

Additional Context
Between clearing cookies, cache, disabling token lists, hard refresh and loading token manually with token address, seems to clear the issue.

Not 100% if this is token list or not, just been seeing a lot of these tickets

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue at app.uniswap.org with the two supplied token addresses and compare their displayed prices and decimals. Then inspect the token-list handling and the behavior after disabling lists or loading a token manually. Done means identifying the source of the nine-decimal discrepancy and confirming that both tokens display the correct price.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.