Uniswap / Uniswap/interface

refactor the currency list token row component to not change every time one of the dependencies changes

Open
#2,726 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

p1 refactor
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/Uniswap/interface/blob/5dac6a03eb508a987fdb1a9cd202359b069208fd/src/components/SearchModal/CurrencyList.tsx#L217-L263

creating a new component forces the entire list to re-render

better to rewrite this so the rendering component doesn't have to memoize everything or else break the component

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/components/SearchModal/CurrencyList.tsx, lines 217-263, and inspect how the currency list row component is created and how its dependencies trigger rendering. Verify the current list behavior while changing a dependency. Done means the row rendering no longer causes the entire list to re-render whenever one dependency changes, without requiring broad memoization.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, performance
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.