Uniswap / Uniswap/interface

price in price bar should be the execution price, not price of 1 base

Open
#2,648 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue p1
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

image
example on arbitrum, selling 35k eth but it says 1 eth = 3800 dai even though there's huge price impact

e.g. here it should say something like 1 ETH = 3.206 DAI ($3.21)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the price bar UI and trace how the displayed quote is calculated for a large ETH sale on Arbitrum. Use the example in the issue to compare the shown 1 ETH value with the execution price, and consider the work complete when the bar reflects the trade's execution price and the displayed wording matches the requested format.

Written by the indexing model from the issue text.

Assessment

Tech stack
blockchain, typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.