ESLint bot may hide failing PRs
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
Bug Description
If a PR fails tests, but has lint issues, the lint commit may make the "Squash and Merge" dialog look like all checks have passed. This is because lint commits only have vercel and lint checks run, and those two may pass without tests passing. This occured in #2467, leading to a commit that had to be reverted.
We should change how the ESLint bot works to avoid this. It is already redundant with the ESLint check. Some options:
- Remove it
- Replace it with a git hook
- Replace it with a local script
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ESLint bot configuration and the checks it creates for pull requests, then review the failure described in #2467. Decide which proposed replacement preserves clear test status in the merge dialog; done means lint changes no longer make a failing PR appear mergeable.
Written by the indexing model from the issue text.
Assessment
- Domain
- ci-cd, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100