Uniswap / Uniswap/interface

While viewing a position, when switching the network, the newly displayed pool makes no sense

Open
#2,378 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description
When I have a position open for display and switch the network, the web page loads anew and displays some random (I guess the position with the number in the URL?) position on this new network. Sometimes it displays astronomical numbers which I think might hint to a bug.

Steps to Reproduce

  1. Be on Arb1
  2. Go to your positions overview and click on a position to view its details
  3. In Metamask switch to Mainnet
  4. Observe web page refreshing with a new (nonsensical) pool

Expected Behavior
I expect on switching the network that I either get redirected to my previously selected position on switching the network or to my positions overview. Or as a temp fix if the position numbered in the URL doesn't exist on this network, display a "position not found (404)" thingy.

Additional Context
Minor issue but could be confusing for new users. On another note, new users probably don't use multiple networks. I still think it's worth fixing, although with a lower priority.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the position detail view and reproduce the network switch from Arbitrum to Mainnet using the steps in the issue. Trace how the position number in the URL is handled after the refresh, then verify that switching networks leads to the selected position, the positions overview, or a position-not-found result rather than unrelated pool data.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.