Uniswap / Uniswap/interface

Fix Token1/Token2 order in user pool overview

Open
#2,355 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description
The pool overview of the user (/pool) does not behave the same way on Arbitrum than it does on Mainnet.
On Mainnet the Order of tokens displayed is for example USDC/ETH, no Arbitrum it is ETH/USDC, no matter which "token order" I chose at minting the pool NFT.

Steps to Reproduce

  1. Check you are on mainnet with MetaMask
  2. Go to https://app.uniswap.org/#/add/ETH/0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48/3000
  3. Add Liquidity
  4. Go to https://app.uniswap.org/#/pool
  5. Observe display/order of pool:
    image
  6. Change Network to Arbitrum in Metamask
  7. Go to https://app.uniswap.org/#/add/ETH/0xFF970A61A04b1cA14834A43f5dE4533eBDDB5CC8/3000
  8. Add Liquidity
  9. Go to https://app.uniswap.org/#/pool
  10. Observe display/order of pool:
    image
  11. Repeat 7, but switch around the order of tokens
  12. Repeat 8 to 10
  13. Observe unexpected behaviour

Expected Behavior
I expect EITHER an option to switch the display of my pool to Token2/Token1 instead of Token1/Token2 or alternatively (less preferred) have the token order on pool NFT minting influence the display order on pool overview.

Additional Context
It goes without saying that especially fiat-related pairs would benefit immensly in readibility if expressed in Crypto:Fiat value than the other way around. In the current state of things it makes it difficult if I need to rebalance because my Liquidity is out of range. I have a hard time finding the already-minted Position NFT because of the way it is displayed.

Also the attached screenshots are exemplary from my current positions hence the difference in pool fee tier and other things.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the ordering discrepancy through the /pool overview on Mainnet and Arbitrum, using the linked add-liquidity flows. Trace how the pool overview chooses Token1 and Token2, then confirm the chosen behavior by checking that positions display consistently and that switching the token order at minting produces the expected result.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.