Using trust wallet with BSC chain selected, it's possible to get uniswap to send transaction thinking they are sent on mainnet
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
Bug Description
A user using app.uniswap.org and trust wallet on BSC sent thoses transactions :
- https://bscscan.com/tx/0xd8c3f2c63567824e6277b18b1c41181d691e1c43289f509e9013365692928e53
- https://bscscan.com/tx/0x19e32ecbfb613e87ff677faca014aef5608919ae8bb6e89435492c1b05490a3a
Thoses are perfectly valid if they were sent on ETH instead.
Steps to Reproduce
? ...
Expected Behavior
Uniswap should print the "Unsuported network" error message and just block the transaction.
Additional Context
Since the estimation has gone thru it's possible the uniswap used the embeded web3 provider or that the network was switched after the estimation was done.
I would bet this code on trust wallet not emiting the event of network changing.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Start by reviewing the two BscScan transactions and reproducing the Trust Wallet flow with BSC selected; trace how network changes and transaction estimation are handled, and consider the issue done when unsupported-network transactions are blocked as described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100