Uniswap / Uniswap/interface

Per-tx-type deadline

Open
#2,141 1 comment 0 reactions 1 assignee View on GitHub

@zzmp is already working on this.

Since Aug 30, 2021.

improvement p1
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Is your feature request related to a problem? Please describe.
Unlike adding/removing liquidity or swaps, fee collection can happen anytime without worrying about price.

And from what I understand, the txn specifies "collect everything", rather than coding in a specific amount available right now in the LP position. Then, as a user who is not in a rush to collect fees, I'd want to set very low gas (tip) and send the Collect Fees txn in the mempool to be executed whenever gas drops to that amount. Could be days and I'm fine with that.

Describe the solution you'd like
It would be nice to increase the deadline of such a transaction, vs other types of transactions that should be shorter time window.

cc @NoahZinsmeister

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.