mixed use of BigNumber and JSBI throughout the interface
Open
Nobody has claimed this yet.
p2
refactor
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
we should just use JSBI since it's a proxy for bigint which can be compiled out at some point in the future
however BigNumber is often used because it's the library that comes with ethers
we should consistently return and use JSBI in all hook interfaces, where currently in many cases we are using BigNumber
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the hook interfaces that currently return or consume ethers BigNumber, then compare them with the JSBI usage across the interface. Review the rationale for JSBI and identify every affected hook boundary. Done means the hook interfaces consistently return and use JSBI instead of BigNumber.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain, frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100