Uniswap / Uniswap/interface

Add Liquidity Settings

Open
#2,048 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

design p2
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

We should re-think the settings menu on the Add Liquidity page.

Issues:

  • Auto slippage does not exist. We're only training the model to predict swap slippage, so using "auto" here is misleading. It's just a normal default slippage.
  • Disable Multihops is not relevant to Adding Liquidity
  • I think Expert Mode is not relevant to Adding Liquidity (?)
Screen Shot 2021-07-13 at 10 53 09 PM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Add Liquidity page and inspect how its settings menu is assembled and how slippage defaults are labeled. Confirm the intended options with the existing swap settings, then ensure the menu presents normal default slippage and excludes settings that do not apply to adding liquidity.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.